Refactor: ReactInstance: Pull "fatal error" bool into JsErrorHandler#43956
Refactor: ReactInstance: Pull "fatal error" bool into JsErrorHandler#43956RSNara wants to merge 5 commits intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55547897 |
Base commit: f77d028 |
|
This pull request was exported from Phabricator. Differential Revision: D55547897 |
|
This pull request was exported from Phabricator. Differential Revision: D55547897 |
|
This pull request was exported from Phabricator. Differential Revision: D55547897 |
|
This pull request was exported from Phabricator. Differential Revision: D55547897 |
|
This pull request was exported from Phabricator. Differential Revision: D55547897 |
|
This pull request was exported from Phabricator. Differential Revision: D55547897 |
|
This pull request was exported from Phabricator. Differential Revision: D55547897 |
|
This pull request was exported from Phabricator. Differential Revision: D55547897 |
|
This pull request was exported from Phabricator. Differential Revision: D55547897 |
|
This pull request was exported from Phabricator. Differential Revision: D55547897 |
|
This pull request was exported from Phabricator. Differential Revision: D55547897 |
Summary: getRuntimeScheduler() allows things to schedule work on the js thread by bypassing main bundle buffering. This is unsafe: almost everything should be using the buffered runtime executor, unless it sets up bindings used in the main bundle. I filed a task for the investigation to see if there's any problems. And added it to the code in this diff. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55547899
Summary: RuntimeScheduler's ErrorUtils.h is redundant. Let's just remove it. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55547905
Summary: Now, all the defaulting is in RuntimeScheduler.h. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55547900
Summary: Just makes it easier to pass around JsErrorHandler. We'll need this in D55547897, when we start storing the "has fataled" boolean inside the JsErrorHandler. Changelog: [internal] Reviewed By: cipolleschi Differential Revision: D55547898
Summary: I think we should try to centralize all things js error handling related inside JsErrorHandler. So, I moved this bool into JsErrorHandler. This makes ReactInstance easier to understand: it removes one member variable from ReactInstance. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55547897
|
This pull request was exported from Phabricator. Differential Revision: D55547897 |
…orHandler (facebook#43956) Summary: I think we should try to centralize all things js error handling related inside JsErrorHandler. So, I moved this bool into JsErrorHandler. This makes ReactInstance easier to understand: it removes one member variable from ReactInstance. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55547897
…orHandler (facebook#43956) Summary: I think we should try to centralize all things js error handling related inside JsErrorHandler. So, I moved this bool into JsErrorHandler. This makes ReactInstance easier to understand: it removes one member variable from ReactInstance. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55547897
|
This pull request has been merged in ba3e078. |
3 participants
Summary:
I think we should try to centralize all things js error handling related inside JsErrorHandler. So, I moved this bool into JsErrorHandler.
This makes ReactInstance easier to understand: it removes one member variable from ReactInstance.
Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D55547897