Fix ClassCastException in ReactModalHostView#43966
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55870250 |
cortinico
force-pushed
the
export-D55870250
branch
from
39507fd to
9d01136
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55870250 |
Summary: The `context` field was confusing. I've renamed it to `currentActivityContext` + I've made sure the `onKey` method is using the right context with a this@ accessor. Changelog: [Android] [Fixed] - Fix ClassCastException in `ReactModalHostView` Reviewed By: GijsWeterings Differential Revision: D55870250
cortinico
force-pushed
the
export-D55870250
branch
from
9d01136 to
e76ada1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55870250 |
Base commit: 3a15af7 |
Contributor
|
This pull request has been merged in 15ff82f. |
|
This pull request was successfully merged by @cortinico in 15ff82f. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
contextfield was confusing. I've renamed it tocurrentActivityContext+I've made sure the
onKeymethod is using the right context with a this@ accessor.Changelog:
[Android] [Fixed] - Fix ClassCastException in
ReactModalHostViewDifferential Revision: D55870250