Unify DevLoadingView code on JS side to be platform-independent#43992
Closed
rshest wants to merge 1 commit into
Closed
Unify DevLoadingView code on JS side to be platform-independent#43992rshest wants to merge 1 commit into
rshest wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55914787 |
…book#43992) Summary: Pull Request resolved: facebook#43992 # Changelog: [Internal] - While looking into implementing native DevLoadingView on non-Android/iOS platform, I realized that the current code inside `LoadingView.android.js`/`LoadingView.ios.js` is functionally identical, and can be transformed into each other with simple code transformations. This diff: * Renames `LoadingView` into `DevLoadingView` (as it's arguably more fitting name, given that it also relies on `NativeDevLoadingView` native module implementation) * Merges the iOS/Android specific JS files into one * Factors usage of the colors out of the actual logic, to better separate presentation from the business logic From the perspective of public APIs there should be no changes. Differential Revision: D55914787
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55914787 |
Base commit: 2fcdab4 |
Contributor
|
This pull request has been merged in 881c0bc. |
|
This pull request was successfully merged by @rshest in 881c0bc. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
While looking into implementing native DevLoadingView on non-Android/iOS platform, I realized that the current code inside
LoadingView.android.js/LoadingView.ios.jsis functionally identical, and can be transformed into each other with simple code transformations.This diff:
LoadingViewintoDevLoadingView(as it's arguably more fitting name, given that it also relies onNativeDevLoadingViewnative module implementation)From the perspective of public APIs there should be no changes.
Differential Revision: D55914787