Move reactperfloggerjni to INTERFACE library#43998
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55919228 |
cortinico
force-pushed
the
export-D55919228
branch
from
300d77e to
e79c77c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55919228 |
Base commit: ea566ad |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55919228 |
Summary: Another library with an empty JNI_OnLoad method. Moving it to `INTERFACE` so it exposes only the Header it has declared. This removes the `libreactperfloggerjni.so` from the final APK. Changelog: [Internal] [Changed] - Move reactperfloggerjni to INTERFACE library Reviewed By: javache Differential Revision: D55919228
cortinico
force-pushed
the
export-D55919228
branch
from
e79c77c to
9e2653c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55919228 |
Contributor
|
This pull request has been merged in 80aa714. |
|
This pull request was successfully merged by @cortinico in 80aa714. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Another library with an empty JNI_OnLoad method.
Moving it to
INTERFACEso it exposes only the Header it has declared.This removes the
libreactperfloggerjni.sofrom the final APK.Changelog:
[Internal] [Changed] - Move reactperfloggerjni to INTERFACE library
Differential Revision: D55919228