add option to set traits when cloning up to the root#44017
Closed
sammy-SC wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55745323 |
Base commit: 5e9ed14 |
sammy-SC
force-pushed
the
export-D55745323
branch
from
8d1f62c to
8082ff0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55745323 |
sammy-SC
force-pushed
the
export-D55745323
branch
from
8082ff0 to
d412603
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55745323 |
sammy-SC
force-pushed
the
export-D55745323
branch
from
d412603 to
d0d6d4b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55745323 |
…44016) Summary: changelog: [internal] Add option to set traits when node is created or cloned via ShadowNodeFragment. This is a pre-requisite for new state reconciliation algorithm. Reviewed By: rubennorte Differential Revision: D55691094
Summary: changelog: [internal] Add an option to mark all nodes clone indirectly by `ShadowNode::cloneTree`. This is a pre-requisite for new state reconciliation algorithm. It will be used to mark part of shadow tree that was affected by native state update. Reviewed By: rubennorte Differential Revision: D55745323
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Apr 11, 2024
…ook#44017) Summary: changelog: [internal] Add an option to mark all nodes clone indirectly by `ShadowNode::cloneTree`. This is a pre-requisite for new state reconciliation algorithm. It will be used to mark part of shadow tree that was affected by native state update. Reviewed By: rubennorte Differential Revision: D55745323
sammy-SC
force-pushed
the
export-D55745323
branch
from
d0d6d4b to
f1d8f87
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55745323 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Apr 11, 2024
…ook#44017) Summary: changelog: [internal] Add an option to mark all nodes clone indirectly by `ShadowNode::cloneTree`. This is a pre-requisite for new state reconciliation algorithm. It will be used to mark part of shadow tree that was affected by native state update. Reviewed By: rubennorte Differential Revision: D55745323
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Apr 11, 2024
…ook#44017) Summary: changelog: [internal] Add an option to mark all nodes clone indirectly by `ShadowNode::cloneTree`. This is a pre-requisite for new state reconciliation algorithm. It will be used to mark part of shadow tree that was affected by native state update. Reviewed By: rubennorte Differential Revision: D55745323
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Apr 11, 2024
…ook#44017) Summary: changelog: [internal] Add an option to mark all nodes clone indirectly by `ShadowNode::cloneTree`. This is a pre-requisite for new state reconciliation algorithm. It will be used to mark part of shadow tree that was affected by native state update. Reviewed By: rubennorte Differential Revision: D55745323
Contributor
|
This pull request has been merged in 3b49db3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
Add an option to mark all nodes clone indirectly by
ShadowNode::cloneTree.This is a pre-requisite for new state reconciliation algorithm. It will be used to mark part of shadow tree that was affected by native state update.
Reviewed By: rubennorte
Differential Revision: D55745323