Fix missing setLeftTopRightBottom method#44033
Closed
mmmoussa wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
@NickGerleman please review |
facebook-github-bot
added
the
Shared with Meta
Base commit: f7eaf63 |
NickGerleman
approved these changes
Apr 11, 2024
Contributor
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@NickGerleman merged this pull request in 08ecdee. |
|
This pull request was successfully merged by @mmmoussa in 08ecdee. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We were seeing errors due to
setLeftTopRightBottombeing called without a check for the Android version despite that method being added in Android API level 29. I've replaced it with the older API methods to fix the issue.This issue originates from #38526
Changelog:
[ANDROID] [FIXED] - Resolved error "No virtual method setLeftTopRightBottom"
Test Plan:
Change is pretty trivial, but we tested it in our production app (Tarteel) for a week and confirmed that the error is resolved.