fix sticky header with tappable element#44046
Closed
sammy-SC wants to merge 1 commit intofacebook:mainfrom
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56005408 |
Summary: changelog: [internal] `passthroughAnimatedPropExplicitValues` from sticky header were removed in D46703731 with assumption that native animations trigger on complete callback and it can be used as a synchronisation point for Fabric. On complete callback is triggered for native animations do trigger on complete callback with one exception: when the native animation is driven by scroll view's content offset. As a result, synchronisation between React and Fabric doesn't happen and Pressability stops working if there is a pressable element in the sticky header. Reviewed By: rubennorte Differential Revision: D56005408
sammy-SC
force-pushed
the
export-D56005408
branch
from
1a40fa3 to
05ae5f2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56005408 |
Base commit: affadb6 |
Contributor
|
This pull request has been merged in b4f9aa1. |
|
This pull request was successfully merged by @sammy-SC in b4f9aa1. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
passthroughAnimatedPropExplicitValuesfrom sticky header were removed in D46703731 with assumption that native animations trigger on complete callback and it can be used as a synchronisation point for Fabric.On complete callback is triggered for native animations do trigger on complete callback with one exception: when the native animation is driven by scroll view's content offset.
As a result, synchronisation between React and Fabric doesn't happen and Pressability stops working if there is a pressable element in the sticky header.
Reviewed By: rubennorte
Differential Revision: D56005408