Minimal implementation of "paused in debugger" overlay#44079
Closed
motiz88 wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56068445 |
Base commit: aa7a0bc |
motiz88
force-pushed
the
export-D56068445
branch
from
217016d to
ae08b17
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56068445 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Apr 15, 2024
…ebook#44079) Summary: Changelog: [Internal] Implements an unstyled, non-interactive version of the "paused in debugger" in-app overlay in Fusebox on Android, based on the event introduced in D56068444. The implementation in `DevSupportManagerBase` is shared across Bridge and Bridgeless. In upcoming diffs in this stack, we'll add interactive features (namely "resume" and "step over" buttons, like in Chrome) and improve the visual styling of this overlay. Differential Revision: D56068445
Summary: Changelog: [Internal] Implements an unstyled, non-interactive version of the "paused in debugger" in-app overlay in Fusebox on Android, based on the event introduced in D56068444. The implementation in `DevSupportManagerBase` is shared across Bridge and Bridgeless. In upcoming diffs in this stack, we'll add interactive features (namely "resume" and "step over" buttons, like in Chrome) and improve the visual styling of this overlay. Reviewed By: hoxyq Differential Revision: D56068445
motiz88
force-pushed
the
export-D56068445
branch
from
ae08b17 to
741ab40
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56068445 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Apr 17, 2024
…ebook#44079) Summary: Changelog: [Internal] Implements an unstyled, non-interactive version of the "paused in debugger" in-app overlay in Fusebox on Android, based on the event introduced in D56068444. The implementation in `DevSupportManagerBase` is shared across Bridge and Bridgeless. In upcoming diffs in this stack, we'll add interactive features (namely "resume" and "step over" buttons, like in Chrome) and improve the visual styling of this overlay. Reviewed By: hoxyq Differential Revision: D56068445
Contributor
|
This pull request has been merged in 6930f3d. |
|
This pull request was successfully merged by @motiz88 in 6930f3d. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Implements an unstyled, non-interactive version of the "paused in debugger" in-app overlay in Fusebox on Android, based on the event introduced in D56068444. The implementation in
DevSupportManagerBaseis shared across Bridge and Bridgeless.In upcoming diffs in this stack, we'll add interactive features (namely "resume" and "step over" buttons, like in Chrome) and improve the visual styling of this overlay to align .
Differential Revision: D56068445