Style pause overlay to be similar to Chrome's#44085
Closed
motiz88 wants to merge 6 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56116881 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56116881 |
motiz88
force-pushed
the
export-D56116881
branch
from
c2dfab6 to
1fa8d49
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56116881 |
motiz88
force-pushed
the
export-D56116881
branch
from
1fa8d49 to
638d58a
Compare
Base commit: 89eb794 |
Differential Revision: D56068445
Differential Revision: D56098083
Differential Revision: D56098084
Differential Revision: D56105051
Differential Revision: D56105959
Summary: Pull Request resolved: facebook#44085 Changelog: [Internal] Styles the Fusebox "paused in debugger" overlay on iOS to look similar to the Chrome implementation (and the Android implementation as of D56105051) instead of using a plain `UIAlertController`. The only thing missing at this point is the custom asset for the "step over" icon. Unlike on Android, RN doesn't currently ship any built-in images for iOS, so I'll figure out how to do that in a separate diff and use a system-provided icon in the interim. Differential Revision: D56116881
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56116881 |
motiz88
force-pushed
the
export-D56116881
branch
from
638d58a to
d8949ee
Compare
Contributor
|
This pull request has been merged in 8872652. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Styles the Fusebox "paused in debugger" overlay on iOS to look similar to the Chrome implementation (and the Android implementation as of D56105051) instead of using a plain
UIAlertController.The only thing missing at this point is the custom asset for the "step over" icon. Unlike on Android, RN doesn't currently ship any built-in images for iOS, so I'll figure out how to do that in a separate diff and use a system-provided icon in the interim.
Differential Revision: D56116881