ReactFeatureFlags.mFabricEnabled should default to ReactFeatureFlags.enableFabricRenderer#44087
Closed
cortinico wants to merge 1 commit into
Closed
ReactFeatureFlags.mFabricEnabled should default to ReactFeatureFlags.enableFabricRenderer#44087cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
…enableFabricRenderer Summary: The `mFabricEnabled` field is initialized to false. This is a misalignment with how other classes are behaving like ReactActivityDelegate. Changelog: [Internal] [Changed] - ReactFeatureFlags.mFabricEnabled should default to ReactFeatureFlags.enableFabricRenderer Reviewed By: arushikesarwani94 Differential Revision: D56013057
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56013057 |
Base commit: 99d0c54 |
Contributor
|
This pull request has been merged in 718041a. |
|
This pull request was successfully merged by @cortinico in 718041a. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
mFabricEnabledfield is initialized to false. This is a misalignment with how other classes are behaving likeReactActivityDelegate.
Changelog:
[Internal] [Changed] - ReactFeatureFlags.mFabricEnabled should default to ReactFeatureFlags.enableFabricRenderer
Reviewed By: arushikesarwani94
Differential Revision: D56013057