Skip to content

Remove getRuntimeExecutor() from ReactContext#44102

Closed
arushikesarwani94 wants to merge 1 commit intofacebook:mainfrom
arushikesarwani94:export-D56151365
Closed

Remove getRuntimeExecutor() from ReactContext#44102
arushikesarwani94 wants to merge 1 commit intofacebook:mainfrom
arushikesarwani94:export-D56151365

Conversation

@arushikesarwani94
Copy link
Copy Markdown
Contributor

Summary:
Remove getRuntimeExecutor() from ReactContext since now it can be accessed through BridgelessCatalystInstance.getRuntimeExecutor() directly

Changelog:
[Android][Deleted] Remove getRuntimeExecutor() from ReactContext since now it can be accessed through BridgelessCatalystInstance in Bridgeless mode

Differential Revision: D56151365

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D56151365

Summary:
Remove `getRuntimeExecutor()` from ReactContext since now it can be accessed through BridgelessCatalystInstance.getRuntimeExecutor() directly

Changelog:
[Android][Removed] - Remove getRuntimeExecutor() from ReactContext since now it can be accessed through BridgelessCatalystInstance in Bridgeless mode

Differential Revision: D56151365
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D56151365

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,385,265 +0
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,760,254 -3
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: e7154bd
Branch: main

arushikesarwani94 added a commit to arushikesarwani94/react-native that referenced this pull request Apr 16, 2024
Summary:

Remove `getRuntimeExecutor()` from ReactContext since now it can be accessed through BridgelessCatalystInstance.getRuntimeExecutor() directly

Changelog:
[Android][Removed] - Remove getRuntimeExecutor() from ReactContext since now it can be accessed through BridgelessCatalystInstance in Bridgeless mode

Reviewed By: RSNara

Differential Revision: D56151365
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in f7b9aaf.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 17, 2024
@github-actions
Copy link
Copy Markdown

This pull request was successfully merged by @arushikesarwani94 in f7b9aaf.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants