Use ClassFinder inside ViewManagerPropertyUpdater#44114
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56191175 |
Summary: In OSS, we should use the ClassFinder wrapper as the `Class.byName` calls will never succeed (we don't run the annotation processor in OSS). Changelog: [Internal] [Changed] - Use ClassFinder inside ViewManagerPropertyUpdater Differential Revision: D56191175
cortinico
force-pushed
the
export-D56191175
branch
from
685f16a to
c6aa8a9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56191175 |
Contributor
|
This pull request has been merged in 56da650. |
|
This pull request was successfully merged by @cortinico in 56da650. When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been reverted by 727c404. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In OSS, we should use the ClassFinder wrapper as the
Class.byNamecalls will never succeed (we don't run the annotation processor in OSS).Changelog:
[Internal] [Changed] - Use ClassFinder inside ViewManagerPropertyUpdater
Differential Revision: D56191175