Back out "Use ClassFinder inside ViewManagerPropertyUpdater"#44152
Closed
janeli-100005636499545 wants to merge 1 commit into
Closed
Back out "Use ClassFinder inside ViewManagerPropertyUpdater"#44152janeli-100005636499545 wants to merge 1 commit into
janeli-100005636499545 wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56311183 |
…k#44152) Summary: We're seeing an increase of crashes on Twilight (https://www.internalfb.com/logview/twilight_android_crashes/d25ec89876821abdd07f98d08a729f7c?trace_tab=0&ds=%7B%22start%22%3A%22-2%20weeks%22%2C%22end%22%3A%22now%22%7D) related to setting fontWeight with Double instead of String. Original commit changeset: a67195e98377 Original Phabricator Diff: D56191175 Changelog: [Internal] [Changed] - Revert use ClassFinder inside ViewManagerPropertyUpdater Differential Revision: D56311183
janeli-100005636499545
force-pushed
the
export-D56311183
branch
from
518cfa6 to
aecfe7f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56311183 |
Base commit: ddc9bd1 |
Contributor
|
This pull request has been merged in 727c404. |
|
This pull request was successfully merged by @janeli-100005636499545 in 727c404. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We're seeing an increase of crashes on Twilight (https://www.internalfb.com/logview/twilight_android_crashes/d25ec89876821abdd07f98d08a729f7c?trace_tab=0&ds=%7B%22start%22%3A%22-2%20weeks%22%2C%22end%22%3A%22now%22%7D) related to setting fontWeight with Double instead of String.
Original commit changeset: a67195e98377
Original Phabricator Diff: D56191175
Changelog:
[Internal] [Changed] - Revert use ClassFinder inside ViewManagerPropertyUpdater
Differential Revision: D56311183