Add missing remove method to addEventListener Jest mocks#44270
Closed
levibuzolic wants to merge 1 commit into
Closed
Add missing remove method to addEventListener Jest mocks#44270levibuzolic wants to merge 1 commit into
remove method to addEventListener Jest mocks#44270levibuzolic wants to merge 1 commit into
Conversation
Adds missing `remove` return object for `Linking.addEventListener` and `AccessibilityInfo.addEventListener` in the Jest mocks
facebook-github-bot
added
the
CLA Signed
levibuzolic
changed the title
remove method to addEventListener mocksremove method to addEventListener Jest mocks
facebook-github-bot
added
the
Shared with Meta
Contributor
|
@levibuzolic Looks good! I also hit this issue today. @cortinico Could we get this merged? |
Contributor
|
@robhogan can you take this on? |
Contributor
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
robhogan
approved these changes
Jun 8, 2024
Contributor
robhogan
left a comment
robhogan
left a comment
There was a problem hiding this comment.
LGTM, thanks @levibuzolic
Contributor
|
This pull request was successfully merged by @levibuzolic in 2483c63. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
While writing some Jest tests, I noticed some instances of the following error:
Looks like there were two cases where the
{remove: () => {}}return result was missing in the provided Jest mocks:AccessibilityInfo.addEventListenerLinking.addEventListenerChangelog:
[GENERAL] [FIXED] - Added missing
removemethods forLinking.addEventListenerandAccessibilityInfo.addEventListenerJest mocksTest Plan
N/A