Skip to content

Remove duplicate SystraceSection.h file#44319

Closed
lyahdav wants to merge 1 commit into
facebook:mainfrom
lyahdav:export-D56659179
Closed

Remove duplicate SystraceSection.h file#44319
lyahdav wants to merge 1 commit into
facebook:mainfrom
lyahdav:export-D56659179

Conversation

@lyahdav
Copy link
Copy Markdown
Contributor

@lyahdav lyahdav commented Apr 29, 2024

Summary:
The files were identical so no need for both. Having both is error-prone as one may be modified without modifying the other.

Changelog: [Internal]

Differential Revision: D56659179

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 29, 2024
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Apr 29, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,495,297 +12
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,867,616 +9
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 362abb9
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D56659179

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D56659179

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D56659179

@lyahdav lyahdav force-pushed the export-D56659179 branch from 9a1280e to 3f3e297 Compare May 6, 2024 20:34
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D56659179

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D56659179

Summary:
Pull Request resolved: facebook#44319

The files were identical so no need for both. Having both is error-prone as one may be modified without modifying the other.

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D56659179
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D56659179

@lyahdav lyahdav force-pushed the export-D56659179 branch from 3f3e297 to 7f8db8e Compare May 6, 2024 20:38
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 8, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 1716428.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2024

This pull request was successfully merged by @lyahdav in 1716428.

When will my fix make it into a release? | How to file a pick request?

kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 11, 2024
Summary:
Pull Request resolved: facebook#44319

The files were identical so no need for both. Having both is error-prone as one may be modified without modifying the other.

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D56659179

fbshipit-source-id: e5f414f0c4a00c126d301a7fcd26eeb17d74a56c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants