conditional Babel registration no longer necessary#44362
Closed
blakef wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56839521 |
Base commit: 3872501 |
Summary: Packages that are built and directly run in the monorepo no longer need to worry about conditionally registering themselves to transpile Flow -> JS at runtime. Our build step strips this file now. Reviewed By: huntie Differential Revision: D56839521
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56839521 |
Contributor
|
This pull request has been merged in 47848ad. |
|
This pull request was successfully merged by @blakef in 47848ad. When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been reverted by 3ddf509. |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44362 Packages that are built and directly run in the monorepo no longer need to worry about conditionally registering themselves to transpile Flow -> JS at runtime. Our build step strips this file now. Changelog: [Internal] changes in published packages no longer require conditional calls to Babel register. Reviewed By: huntie Differential Revision: D56839521 fbshipit-source-id: 6bec706c639f1ab4138e0b790be8a07654333046
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Packages that are built and directly run in the monorepo no longer need to worry about
conditionally registering themselves to transpile Flow -> JS at runtime. Our build step
strips this file now.
Differential Revision: D56839521