Skip to content

ReactEventEmitter null fix#44394

Closed
tdn120 wants to merge 2 commits into
facebook:mainfrom
tdn120:export-D56898951
Closed

ReactEventEmitter null fix#44394
tdn120 wants to merge 2 commits into
facebook:mainfrom
tdn120:export-D56898951

Conversation

@tdn120

@tdn120 tdn120 commented May 2, 2024

Copy link
Copy Markdown

Summary:
Lint fix - flip to a guaranteed non-null value instead of the nullable field

Changelog: [Internal]

Differential Revision: D56898951

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 2, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D56898951

@analysis-bot

analysis-bot commented May 2, 2024

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,495,286 -1
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,867,613 -9
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 06eea61
Branch: main

@tdn120 tdn120 force-pushed the export-D56898951 branch from 1a438ac to c93161c Compare May 6, 2024 21:11
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D56898951

Thomas Nardone added 2 commits May 7, 2024 06:15
Summary:

Updating null annotations to match convention.

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D56895070
Summary:

Lint fix - flip to a guaranteed non-null value instead of the nullable field

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D56898951
@tdn120 tdn120 force-pushed the export-D56898951 branch from c93161c to 94b4ec7 Compare May 7, 2024 13:15
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D56898951

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 7, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in c7dcdc1.

kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 11, 2024
Summary:
Pull Request resolved: facebook#44394

Lint fix - flip to a guaranteed non-null value instead of the nullable field

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D56898951

fbshipit-source-id: 8740ed77d71a827c7ce80b2df941d24985339619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants