Add "Refresh Image" to RNTester Image.fadeDuration example#44414
Closed
rshest wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56978930 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56978930 |
Base commit: a881b51 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56978930 |
…44414) Summary: # Changelog: [Internal] - I noticed that "Image/Fade Duration" test in RNTester is practically useless, as at the moment one scrolls to the test, the fading is most probably had already ended. This adds a "button" to refresh the image and be able to see the fading in again and again, if desired. Differential Revision: D56978930
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56978930 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
May 5, 2024
…acebook#44414) Summary: # Changelog: [Internal] - I noticed that "Image/Fade Duration" test in RNTester is practically useless, as at the moment one scrolls to the test, the fading is most probably had already ended. This adds a "button" to refresh the image and be able to see the fading in again and again, if desired. Differential Revision: D56978930
Contributor
|
This pull request has been merged in 9d2cf42. |
|
This pull request was successfully merged by @rshest in 9d2cf42. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
May 6, 2024
…44414) Summary: Pull Request resolved: facebook#44414 # Changelog: [Internal] - I noticed that "Image/Fade Duration" test in RNTester is practically useless, as at the moment one scrolls to the test, the fading is most probably had already ended. This adds a "button" to refresh the image and be able to see the fading in again and again, if desired. Reviewed By: christophpurrer Differential Revision: D56978930 fbshipit-source-id: 02873b45600ad319b0b1077467f599dc1a54bee3
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…44414) Summary: Pull Request resolved: facebook#44414 # Changelog: [Internal] - I noticed that "Image/Fade Duration" test in RNTester is practically useless, as at the moment one scrolls to the test, the fading is most probably had already ended. This adds a "button" to refresh the image and be able to see the fading in again and again, if desired. Reviewed By: christophpurrer Differential Revision: D56978930 fbshipit-source-id: 02873b45600ad319b0b1077467f599dc1a54bee3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
I noticed that "Image/Fade Duration" test in RNTester is practically useless, as at the moment one scrolls to the test, the fading is most probably had already ended.
This adds a "button" to refresh the image and be able to see the fading in again and again, if desired.
Differential Revision: D56978930