Fix HermesExecutorFactory build error#44423
Closed
Kudo wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Base commit: 362abb9 |
facebook-github-bot
added
the
Shared with Meta
Contributor
|
@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
This pull request was successfully merged by @Kudo in 2d46dbe. When will my fix make it into a release? | How to file a pick request? |
Contributor
Author
|
thanks for merging the fix 🙏 |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: facebook@7af288e5 introduced a breaking change for whoever importing HermesExecutorFactory.h, because the `hermes/inspector-modern/chrome/HermesRuntimeTargetDelegate.h` is not a public header. Also the nested import is not ideal for CocoaPods or use_frameworks. I think HermesRuntimeTargetDelegate could be an implementation detail that hide from header. This PR tries to turn the ownership declaration from std::optional to std::unique_ptr, so that we could hide the concrete type. ## Changelog: [IOS] [FIXED] - Fixed `HermesExecutorFactory.h` build error when importing its private header Pull Request resolved: facebook#44423 Test Plan: should introduce no breaking change and ci passed Reviewed By: cipolleschi Differential Revision: D57041498 Pulled By: huntie fbshipit-source-id: bfa10c7307458813d99c52313682dd62bea80f19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
7af288e5 introduced a breaking change for whoever importing HermesExecutorFactory.h, because the
hermes/inspector-modern/chrome/HermesRuntimeTargetDelegate.his not a public header. Also the nested import is not ideal for CocoaPods or use_frameworks.I think HermesRuntimeTargetDelegate could be an implementation detail that hide from header. This PR tries to turn the ownership declaration from std::optional to std::unique_ptr, so that we could hide the concrete type.
Changelog:
[IOS] [FIXED] - Fixed
HermesExecutorFactory.hbuild error when importing its private headerTest Plan:
should introduce no breaking change and ci passed