Simplify timer deletion code#44443
Closed
javache wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57049086 |
Summary: TextInputs' `onTextInput` callback was removed way back in React Native 0.62 with facebook@3f7e0a2 , but remnants of the implementation exists. Let's just remove it altogether? ## Changelog: [IOS] [REMOVED] - Remove deprecated onTextInput callback Pull Request resolved: facebook#44351 Test Plan: CI should pass Differential Revision: D56804590 Pulled By: javache
Summary: Pull Request resolved: facebook#44443 Call `erase` directly instead of doing `find` + `erase`. Changelog: [Internal] Differential Revision: D57049086
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57049086 |
Base commit: 06eea61 |
Contributor
|
This pull request has been merged in 29c3bc0. |
|
This pull request was successfully merged by @javache in 29c3bc0. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44443 Call `erase` directly instead of doing `find` + `erase`. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D57049086 fbshipit-source-id: b8a30b66f080897fef31677b2c9e1cdff99a71d2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Call
erasedirectly instead of doingfind+erase.Changelog: [Internal]
Differential Revision: D57049086