RN tester example for filters#44459
Closed
joevilches wants to merge 7 commits into
Closed
Conversation
Summary: This works similar to how `transform` is parsed in that it sets tags on the View to actually update the prop when all the prop setters are done being called since the parsing of the array is not very trivial. Besides that it is pretty simple and just calls into `FilterHelper` and uses `setRenderEffect`: https://developer.android.com/reference/android/view/View#setRenderEffect(android.graphics.RenderEffect). That API is only exposed in version 31 of the SDK so it is gated accordingly. Differential Revision: D54640600
Differential Revision: D56847475
Differential Revision: D54640629
Differential Revision: D55044674
Differential Revision: D56447175
Differential Revision: D56845572
Summary: tsia Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D56857709
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56857709 |
Base commit: be09d12 |
Contributor
|
This pull request has been merged in 88ab1ce. |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44459 tsia Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D56857709 fbshipit-source-id: 4bbeeed89ec40ca5c9a3472578388699e47f9c9c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
tsia
Changelog: [Internal]
Reviewed By: NickGerleman
Differential Revision: D56857709