Skip to content

Make INTERNAL_CALLSITES_REGEX work with Windows paths#44469

Closed
motiz88 wants to merge 2 commits into
facebook:mainfrom
motiz88:export-D57091214
Closed

Make INTERNAL_CALLSITES_REGEX work with Windows paths#44469
motiz88 wants to merge 2 commits into
facebook:mainfrom
motiz88:export-D57091214

Conversation

@motiz88
Copy link
Copy Markdown
Contributor

@motiz88 motiz88 commented May 8, 2024

Summary: Changelog: [General][Fixed] LogBox and Chrome DevTools stack frame collapsing patterns are now compatible with Windows file paths.

Differential Revision: D57091214

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 8, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D57091214

motiz88 added 2 commits May 7, 2024 23:58
…-server in Fusebox experiment (facebook#44444)

Summary:

Changelog: [Internal] - Request bundles with `excludeSource=true` and `sourcePaths=url-server`.

Changes RN's bundle client to request more efficient source maps from Metro by relying on lazy-fetching of source contents.

NOTE: Requires a Metro version with D56952064 and D56952063 (not yet released on npm) to work properly.

Reviewed By: robhogan

Differential Revision: D56952065
Summary:

Changelog: [General][Fixed] LogBox and Chrome DevTools stack frame collapsing patterns are now compatible with Windows file paths.

Differential Revision: D57091214
@motiz88 motiz88 force-pushed the export-D57091214 branch from e6a3f55 to 92c7da7 Compare May 8, 2024 06:58
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D57091214

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,495,370 -9
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,867,572 +0
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: deee037
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 8d0046a.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 8, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2024

This pull request was successfully merged by @motiz88 in 8d0046a.

When will my fix make it into a release? | How to file a pick request?

kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 11, 2024
Summary:
Pull Request resolved: facebook#44469

Changelog: [General][Fixed] LogBox and Chrome DevTools stack frame collapsing patterns are now compatible with Windows file paths.

Reviewed By: GijsWeterings

Differential Revision: D57091214

fbshipit-source-id: f62d9fe7f3d4f91ed8ea07521b174989c2dd1c81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants