Skip to content

Add BindingsInstaller for TurboModules on Android#44485

Closed
Kudo wants to merge 1 commit into
facebook:mainfrom
Kudo:@kudo/turbo-module-install-jsi-android
Closed

Add BindingsInstaller for TurboModules on Android#44485
Kudo wants to merge 1 commit into
facebook:mainfrom
Kudo:@kudo/turbo-module-install-jsi-android

Conversation

@Kudo
Copy link
Copy Markdown
Contributor

@Kudo Kudo commented May 8, 2024

Summary:

Add synchronous JS bindings installation for TurboModules on Android. That would help some 3rd party JSI based modules to install JS bindings easier.
The iOS implementation will be in a separate PR.
Re-create from #43110

Changelog:

[ANDROID] [ADDED] - Add BindingsInstaller for TurboModules

Test Plan:

Added test in RN-Tester TurboModule test case

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Expo Partner: Expo Partner labels May 8, 2024
@Kudo Kudo closed this May 8, 2024
@Kudo Kudo deleted the @kudo/turbo-module-install-jsi-android branch May 8, 2024 13:02
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,528,331 +32,954
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,900,398 +32,822
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 8d0046a
Branch: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Expo Partner: Expo Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants