Make relevant TextInput examples not depend on top window size#44517
Closed
rshest wants to merge 1 commit into
Closed
Make relevant TextInput examples not depend on top window size#44517rshest wants to merge 1 commit into
rshest wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57196308 |
…ook#44517) Summary: # Changelog: [Internal] - A follow-up to facebook#44505, turns out this is also an issue for TextInput examples, which work of assumption of some of the text input fields being of limited width, but in practice growing to occupy the parent window width, which can be quite large on platforms different from the classic mobile ones. This diff makes the corresponding tests more practical, not expanding to the parent window anymore. Differential Revision: D57196308
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57196308 |
|
This pull request was successfully merged by @rshest in 8c3260f. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…ook#44517) Summary: Pull Request resolved: facebook#44517 # Changelog: [Internal] - A follow-up to facebook#44505, turns out this is also an issue for TextInput examples, which work of assumption of some of the text input fields being of limited width, but in practice growing to occupy the parent window width, which can be quite large on platforms different from the classic mobile ones. This diff makes the corresponding tests more practical, not expanding to the parent window anymore. Reviewed By: christophpurrer Differential Revision: D57196308 fbshipit-source-id: 7018e8c51adb70fe6a03e50d71eff9ba997fd07a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
A follow-up to #44505, turns out this is also an issue for TextInput examples, which work of assumption of some of the text input fields being of limited width, but in practice growing to occupy the parent window width, which can be quite large on platforms different from the classic mobile ones.
This diff makes the corresponding tests more practical, not expanding to the parent window anymore.
Differential Revision: D57196308