Mark IntBufferBatchMountItem as nullsafe#44540
Closed
NickGerleman wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57249958 |
Summary: This is the default for new Android projects, and is needed to have layout direction APIs do anything, or for e.g. scrollbar to show up in expected place. Set this in the manifest for new apps by default. Differential Revision: D57248205
…id] Propagate layout direction to Android views Differential Revision: D57248417
Summary: Pull Request resolved: facebook#44540 Noticed when running `arc nn` > Advice xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/mountitems/IntBufferBatchMountItem.java:39 > [Class has 0 issues and can be marked Nullsafe] Congrats! `IntBufferBatchMountItem` is free of nullability issues. Mark it `Nullsafe(Nullsafe.Mode.LOCAL)` to prevent regressions. Changelog: [Internal] Differential Revision: D57249958
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57249958 |
NickGerleman
force-pushed
the
export-D57249958
branch
from
52c43d1 to
709eb2c
Compare
Base commit: 3f17c8b |
Contributor
|
This pull request has been merged in 2cc3ba1. |
|
This pull request was successfully merged by @NickGerleman in 2cc3ba1. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44540 Noticed when running `arc nn` > Advice xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/mountitems/IntBufferBatchMountItem.java:39 > [Class has 0 issues and can be marked Nullsafe] Congrats! `IntBufferBatchMountItem` is free of nullability issues. Mark it `Nullsafe(Nullsafe.Mode.LOCAL)` to prevent regressions. Changelog: [Internal] Reviewed By: rshest Differential Revision: D57249958 fbshipit-source-id: d38559a3fafae0ad778c19dd85c5da610a650d7c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Noticed when running
arc nnChangelog: [Internal]
Differential Revision: D57249958