Revert debugger launch behaviour to default profile#44638
Closed
huntie wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57619542 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57619542 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57619542 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57619542 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
May 24, 2024
Summary: Reverts the debugger launch flow to use the default `ChromeLauncher` profile. This is the approach used in the current `--experimental-debugger` experiment and by Expo. This is motivated after a review of the tradeoffs of a guest profile — which allow us to programatically quit the browser process, however takes over system URL handling. Changelog: [Internal] Differential Revision: D57619542
huntie
added a commit
to huntie/react-native
that referenced
this pull request
May 24, 2024
Summary: Reverts the debugger launch flow to use the default `ChromeLauncher` profile. This is the approach used in the current `--experimental-debugger` experiment and by Expo. This is motivated after a review of the tradeoffs of a guest profile — which allow us to programatically quit the browser process, however takes over system URL handling. Changelog: [Internal] Differential Revision: D57619542
Summary: Reverts the debugger launch flow to use the default `ChromeLauncher` profile. This is the approach used in the current `--experimental-debugger` experiment and by Expo. This is motivated after a review of the tradeoffs of a guest profile — which allow us to programatically quit the browser process, however takes over system URL handling. Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D57619542
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57619542 |
Contributor
|
This pull request has been merged in 7e0f86f. |
|
This pull request was successfully merged by @huntie in 7e0f86f. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44638 Reverts the debugger launch flow to use the default `ChromeLauncher` profile. This is the approach used in the current `--experimental-debugger` experiment and by Expo. This is motivated after a review of the tradeoffs of a guest profile — which allow us to programatically quit the browser process, however takes over system URL handling. Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D57619542 fbshipit-source-id: 3713e1cf8eed61e7a70ed1e4eb58f02da845155f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reverts the debugger launch flow to use the default
ChromeLauncherprofile. This is the approach used in the current--experimental-debuggerexperiment and by Expo.This is motivated after a review of the tradeoffs of a guest profile — which allow us to programatically quit the browser process, however takes over system URL handling.
Changelog: [Internal]
Differential Revision: D57619542