Skip to content

Make dimension units case insensitive#44639

Closed
NickGerleman wants to merge 1 commit into
facebook:mainfrom
NickGerleman:export-D57620806
Closed

Make dimension units case insensitive#44639
NickGerleman wants to merge 1 commit into
facebook:mainfrom
NickGerleman:export-D57620806

Conversation

@NickGerleman
Copy link
Copy Markdown
Contributor

Summary:
https://www.w3.org/TR/css-values-4/#dimensions

Like keywords, unit identifiers are ASCII case-insensitive.

Changelog: [Internal]

Reviewed By: joevilches

Differential Revision: D57620806

Summary:
https://www.w3.org/TR/css-values-4/#dimensions

> Like keywords, unit identifiers are ASCII case-insensitive.


Changelog: [Internal]

Reviewed By: joevilches

Differential Revision: D57620806
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 21, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D57620806

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,542,741 -10
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,912,798 -19
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: cd1ddbb
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 21, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 644facd.

@github-actions
Copy link
Copy Markdown

This pull request was successfully merged by @NickGerleman in 644facd.

When will my fix make it into a release? | How to file a pick request?

kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 11, 2024
Summary:
Pull Request resolved: facebook#44639

https://www.w3.org/TR/css-values-4/#dimensions

> Like keywords, unit identifiers are ASCII case-insensitive.

Changelog: [Internal]

Reviewed By: joevilches

Differential Revision: D57620806

fbshipit-source-id: 26946ed4031f379888651c08b1b0895ac701a320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants