Skip to content

Do not strip CxxInspectorPackagerConnection.DelegateImpl methods#44650

Closed
motiz88 wants to merge 1 commit into
facebook:mainfrom
motiz88:export-D57708376
Closed

Do not strip CxxInspectorPackagerConnection.DelegateImpl methods#44650
motiz88 wants to merge 1 commit into
facebook:mainfrom
motiz88:export-D57708376

Conversation

@motiz88
Copy link
Copy Markdown
Contributor

@motiz88 motiz88 commented May 23, 2024

Summary:
Changelog: [Internal]

Adds the missing DoNotStrip annotations to methods of CxxInspectorPackagerConnection.DelegateImpl that are called from C++.

Differential Revision: D57708376

Summary:
Changelog: [Internal]

Adds the missing `DoNotStrip` annotations to methods of `CxxInspectorPackagerConnection.DelegateImpl` that are called from C++.

Differential Revision: D57708376
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 23, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D57708376

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,559,078 +9
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,912,785 +8
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 95de14d
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 23, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 5a6b64f.

@github-actions
Copy link
Copy Markdown

This pull request was successfully merged by @motiz88 in 5a6b64f.

When will my fix make it into a release? | How to file a pick request?

kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 11, 2024
…ebook#44650)

Summary:
Pull Request resolved: facebook#44650

Changelog: [Internal]

Adds the missing `DoNotStrip` annotations to methods of `CxxInspectorPackagerConnection.DelegateImpl` that are called from C++.

Reviewed By: huntie

Differential Revision: D57708376

fbshipit-source-id: 8a72b19211b60ce7a6049079e5ecfc2e96bc974f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants