Skip to content

Remove inspectorEnableCxxInspectorPackagerConnection flag#44662

Closed
huntie wants to merge 2 commits into
facebook:mainfrom
huntie:export-D57730921
Closed

Remove inspectorEnableCxxInspectorPackagerConnection flag#44662
huntie wants to merge 2 commits into
facebook:mainfrom
huntie:export-D57730921

Conversation

@huntie
Copy link
Copy Markdown
Member

@huntie huntie commented May 23, 2024

Summary: Changelog: [Internal]

Differential Revision: D57730921

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 23, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D57730921

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented May 23, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,543,500 -16,227
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,896,513 -16,423
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: c13790f
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D57730921

@huntie huntie force-pushed the export-D57730921 branch from ede39a8 to deef741 Compare May 24, 2024 10:14
huntie added 2 commits May 24, 2024 08:02
Summary: Changelog: [Internal]

Differential Revision: D57737342
…4662)

Summary:
Pull Request resolved: facebook#44662

- Remove `inspectorEnableCxxInspectorPackagerConnection` feature flag.
- Replace existing checks with `getEnableModernCDPRegistry()`.

Changelog: [Internal]

Differential Revision: D57730921
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D57730921

@huntie huntie force-pushed the export-D57730921 branch from deef741 to 5f7d5e2 Compare May 24, 2024 15:17
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 26, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in a908387.

@github-actions
Copy link
Copy Markdown

This pull request was successfully merged by @huntie in a908387.

When will my fix make it into a release? | How to file a pick request?

kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 11, 2024
…4662)

Summary:
Pull Request resolved: facebook#44662

- Remove `inspectorEnableCxxInspectorPackagerConnection` feature flag.
- Replace existing checks with `getEnableModernCDPRegistry()`.

Changelog: [Internal]

Reviewed By: hoxyq

Differential Revision: D57730921

fbshipit-source-id: fd13b84a826a4fa5973053a721d311c7d68dd2f5
@huntie huntie deleted the export-D57730921 branch September 9, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants