Add suppression for deprecated setters and getters#44676
Closed
Abbondanzo wants to merge 1 commit into
Closed
Conversation
Summary: Some of the setters and getters in these functions, like [`getStatusBarColor`](https://developer.android.com/reference/android/view/Window#getStatusBarColor), have been marked as deprecated in [`VANILLA_ICE_CREAM`](https://developer.android.com/reference/android/os/Build.VERSION_CODES#VANILLA_ICE_CREAM). This change suppresses deprecation warnings until we can move to newer alternatives. ## Changelog [Android] [Changed] - Added suppression for deprecated getter/setter usage in StatusBarModule Differential Revision: D57780503
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57780503 |
Base commit: c13790f |
Contributor
|
This pull request has been merged in ac51dee. |
|
This pull request was successfully merged by Peter Abbondanzo in ac51dee. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44676 Some of the setters and getters in these functions, like [`getStatusBarColor`](https://developer.android.com/reference/android/view/Window#getStatusBarColor), have been marked as deprecated in [`VANILLA_ICE_CREAM`](https://developer.android.com/reference/android/os/Build.VERSION_CODES#VANILLA_ICE_CREAM). This change suppresses deprecation warnings until we can move to newer alternatives. ## Changelog [Android] [Changed] - Added suppression for deprecated getter/setter usage in StatusBarModule Reviewed By: sumkit Differential Revision: D57780503 fbshipit-source-id: 6201f7a3e597fef420de0f80dd2243bee78bc583
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Some of the setters and getters in these functions, like
getStatusBarColor, have been marked as deprecated inVANILLA_ICE_CREAM. This change suppresses deprecation warnings until we can move to newer alternatives.Changelog
[Android] [Changed] - Added suppression for deprecated getter/setter usage in StatusBarModule
Differential Revision: D57780503