Make consistent focusable behavior#44705
Closed
rozele wants to merge 1 commit into
Closed
Conversation
Summary: `focusable` props behaviors are inconsistent across different flavors of Touchable components. Some use the disabled prop to check if the component should be focusable, others do not. This ensures all Touchable* component flavors use the disabled prop. ## Changelog [General][Fixed] Fixed inconsistency in TouchableX component disabled / focusable behavior Differential Revision: D57910488
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57910488 |
Contributor
|
This pull request has been merged in 775713c. |
|
This pull request was successfully merged by @rozele in 775713c. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44705 `focusable` props behaviors are inconsistent across different flavors of Touchable components. Some use the disabled prop to check if the component should be focusable, others do not. This ensures all Touchable* component flavors use the disabled prop. ## Changelog [General][Fixed] Fixed inconsistency in TouchableX component disabled / focusable behavior Reviewed By: yungsters Differential Revision: D57910488 fbshipit-source-id: af17227403338fcd5bebd9ba7c3172b4c6776e1f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
focusableprops behaviors are inconsistent across different flavors of Touchable components. Some use the disabled prop to check if the component should be focusable, others do not.This ensures all Touchable* component flavors use the disabled prop.
Changelog
[General][Fixed] Fixed inconsistency in TouchableX component disabled / focusable behavior
Differential Revision: D57910488