Add extra logging for invalid Paragraph Attributes MapBuffer#44709
Closed
NickGerleman wants to merge 1 commit into
Closed
Add extra logging for invalid Paragraph Attributes MapBuffer#44709NickGerleman wants to merge 1 commit into
NickGerleman wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57925730 |
…k#44709) Summary: Add some extra logging to try to figure out heisenbug, where we cannot find MapBuffer key that we should expect to be present, only during view preallocation. ReadableMapBuffer toString() will itself iterate through MapBuffer entries, so this might not return something sane if underlying MapBuffer is corrupt or wrongly oriented, but should give us more context. Changelog: [Internal] Differential Revision: D57925730
NickGerleman
force-pushed
the
export-D57925730
branch
from
3074be0 to
89c3f48
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57925730 |
Base commit: 3c31e9d |
Contributor
|
This pull request has been merged in c2c9b27. |
|
This pull request was successfully merged by @NickGerleman in c2c9b27. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…k#44709) Summary: Pull Request resolved: facebook#44709 Add some extra logging to try to figure out heisenbug, where we cannot find MapBuffer key that we should expect to be present, only during view preallocation. ReadableMapBuffer toString() will itself iterate through MapBuffer entries, so this might not return something sane if underlying MapBuffer is corrupt or wrongly oriented, but should give us more context. We also need to be careful here, to avoid logging the actual state mapbuffer or its binary which may contain text content. Only the paragraph attributes. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D57925730 fbshipit-source-id: cecca1a1fe53b4b417d520e65c30d47243cb2fb2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add some extra logging to try to figure out heisenbug, where we cannot find MapBuffer key that we should expect to be present, only during view preallocation.
ReadableMapBuffer toString() will itself iterate through MapBuffer entries, so this might not return something sane if underlying MapBuffer is corrupt or wrongly oriented, but should give us more context.
Changelog: [Internal]
Differential Revision: D57925730