Add more clipping examples#44735
Closed
NickGerleman wants to merge 3 commits into
Closed
Conversation
…44732) Summary: `getBorderBoxPath()` and `getPaddingBoxPath()` currently assume `updatePath()` will set a path, but this does not happen on Android 24 emulators where it seems like `onBoundsChanged` isn't called to set flag for needing update. But, the current design tries to be lazy with path generation, and these are probably more expensive to clip, so we should really make these functions return nullable value, then fall back to rect, like the internals of `CSSBackgroundDrawable`, and how I misremembered these as working in the view code added originally in D57668976. Changelog: [Internal] Differential Revision: D57951852
Summary: We are returning a Path to callers, which shouldn't be mutated. This isn't really safe. Return a copy to external callers instead, if they need a path to work with. Changelog: [Internal] Differential Revision: D57996157
Summary: Add some more examples of overflow clipping for scrollview, text, textinput. Changelog: [Internal] Differential Revision: D57999676
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57999676 |
Base commit: c2c9b27 |
Contributor
|
This pull request has been merged in c046198. |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44735 Add some more examples of overflow clipping for scrollview, text, textinput. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D57999676 fbshipit-source-id: dfede321b2c7c61dda3afaf2aea784f6c295c384
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add some more examples of overflow clipping for scrollview, text, textinput.
Changelog: [Internal]
Differential Revision: D57999676