Add unit test for runtime reference updates on clone#44758
Closed
lenaic wants to merge 6 commits into
Closed
Conversation
added 5 commits
June 1, 2024 18:49
Summary: Adding a feature flag to conditionally enable shadow node reference updates when cloning nodes within react native. The feature flag will be used to run an experiment with this feature. Differential Revision: D57860868
Summary: React native clones shadow nodes internally without providing the new instances to the React renderer (current fiber tree). To support updating the shadow node references held by the JS side, this diff wraps the returned shadow nodes and adds a link to the runtime reference on the shadow node instance. This will allow for updating the shadow node references held within the JS runtime from the native side. Differential Revision: https://www.internalfb.com/diff/D57860869?entry_point=27
Summary: Any shadow node cloning happening outside the execution of the UIManagerBinding cloneNode call should guarantee that the references held to the shadow node are updated to the latest revision. This guarantees that the React renderer's current fiber tree holds references to the ShadowNode instances that acually were layed out and committed for rendering on the native side. Maintaining these references up to date on the JS current fiber tree allows to maximize layout caches on subsequent commits. Differential Revision: https://www.internalfb.com/diff/D57860867?entry_point=27
Differential Revision: D58000072
Differential Revision: D58000071
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57893880 |
Base commit: a6a7cdf |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57893880 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57893880 |
Summary: Pull Request resolved: facebook#44758 Changelog: [Internal] Adding a unit test to verify that the shadow node references are correctly updated to reference the new shadow node instance after cloning. Reviewed By: sammy-SC Differential Revision: D57893880
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57893880 |
Contributor
|
This pull request has been merged in 839ee0a. |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44758 Changelog: [Internal] Adding a unit test to verify that the shadow node references are correctly updated to reference the new shadow node instance after cloning. Reviewed By: sammy-SC Differential Revision: D57893880 fbshipit-source-id: 6e36ca3d1b159f7bafb084246f714f3bfec58c1e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Adding a unit test to verify that the shadow node references are correctly updated to reference the new shadow node instance after cloning.
Reviewed By: sammy-SC
Differential Revision: D57893880