Add Java assertions for order of Host/Instance inspector target teardown#44766
Closed
motiz88 wants to merge 1 commit into
Closed
Add Java assertions for order of Host/Instance inspector target teardown#44766motiz88 wants to merge 1 commit into
motiz88 wants to merge 1 commit into
Conversation
Summary: Changelog: [Internal] There is currently a lifecycle bug in both the Bridge (`com.facebook.react.bridge`) and Bridgeless (`com.facebook.react.runtime`) integrations of Fusebox in React Native Android, whereby `HostTarget::unregisterInstance` gets called after the `HostTarget` has been destroyed. This manifests as a handful of related C++ crashes depending on the exact circumstances and build flags. This diff makes the bug trigger a Java assertion instead of a C++ crash for ease of debugging. The next diff in the stack will actually fix the lifecycle issue. Differential Revision: D58031217
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58031217 |
Base commit: a6a7cdf |
Contributor
|
This pull request has been merged in 6c2e1cf. |
|
This pull request was successfully merged by @motiz88 in 6c2e1cf. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…own (facebook#44766) Summary: Pull Request resolved: facebook#44766 Changelog: [Internal] There is currently a lifecycle bug in both the Bridge (`com.facebook.react.bridge`) and Bridgeless (`com.facebook.react.runtime`) integrations of Fusebox in React Native Android, whereby `HostTarget::unregisterInstance` gets called after the `HostTarget` has been destroyed. This manifests as a handful of related C++ crashes depending on the exact circumstances and build flags. This diff makes the bug trigger a Java assertion instead of a C++ crash for ease of debugging. The next diff in the stack will actually fix the lifecycle issue. Reviewed By: hoxyq Differential Revision: D58031217 fbshipit-source-id: 9301b34edf5e526cbc72d86e78b328d29c9921b5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
There is currently a lifecycle bug in both the Bridge (
com.facebook.react.bridge) and Bridgeless (com.facebook.react.runtime) integrations of Fusebox in React Native Android, wherebyHostTarget::unregisterInstancegets called after theHostTargethas been destroyed. This manifests as a handful of related C++ crashes depending on the exact circumstances and build flags.This diff makes the bug trigger a Java assertion instead of a C++ crash for ease of debugging. The next diff in the stack will actually fix the lifecycle issue.
Differential Revision: D58031217