Remove the workaround to import the Paper renderer#44814
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58234325 |
Base commit: 7781c27 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58234325 |
cipolleschi
force-pushed
the
export-D58234325
branch
from
2298757 to
e1f94f3
Compare
Summary: Pull Request resolved: facebook#44814 We needed this workaround to import the paper renderer in the New Architecture to make sure that the event emitter is properly registered before we use it. With the previous change, we don't need this lines of code anymore as we are using a different mechanism for the events. ## Changelog: [Internal] - Avoid to import the old Renderer in the New Architecture ## Facebook: This diff was initially part of D57097880, but I split them for the OTA Reviewed By: cortinico Differential Revision: D58234325
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58234325 |
cipolleschi
force-pushed
the
export-D58234325
branch
from
e1f94f3 to
0aa48d5
Compare
Contributor
|
This pull request has been merged in aead3db. |
|
This pull request was successfully merged by @cipolleschi in aead3db. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We needed this workaround to import the paper renderer in the New Architecture to make sure that the event emitter is properly registered before we use it.
With the previous change, we don't need this lines of code anymore as we are using a different mechanism for the events.
Changelog:
[Internal] - Avoid to import the old Renderer in the New Architecture
Facebook:
This diff was initially part of D57097880, but I split them for the OTA
Reviewed By: cortinico
Differential Revision: D58234325