Modify IntersectionObserver example in RNTester to showcase changes in intersection due to changes in layout, instead of scroll#44823
Closed
rubennorte wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58260057 |
…n intersection due to changes in layout, instead of scroll (facebook#44823) Summary: Pull Request resolved: facebook#44823 Changelog: [internal] This modifies the example for `IntersectionObserver` in RNTester to test that the API reports changes in intersection also coming from changes in layout (previously is was only from changes in scroll position). Reviewed By: javache Differential Revision: D58260057
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58260057 |
rubennorte
force-pushed
the
export-D58260057
branch
from
ad8bf28 to
b312e9a
Compare
Contributor
|
This pull request has been merged in e94852f. |
|
This pull request was successfully merged by @rubennorte in e94852f. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This modifies the example for
IntersectionObserverin RNTester to test that the API reports changes in intersection also coming from changes in layout (previously is was only from changes in scroll position).Differential Revision: D58260057