Remove nonstandard "vm" field from modern CDP targets#44835
Closed
huntie wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58285587 |
Base commit: b0c0bb4 |
Summary: Pull Request resolved: facebook#44835 As titled. The `vm` field is not part of the CDP spec and will not be used by the modern debugger frontend or proxy. This change affects modern CDP targets only (using `InspectorPackagerConnection`). We aim to enable sharing of more detailed metadata over 1/ a new, dedicated CDP domain, and 2/ namespaced under the existing `reactNative` field (for the latter, strictly limited to metadata necessary for dev server functionality). Changelog: [Internal] (Note: `/json` endpoint behaviour is unchanged for legacy CDP targets) Reviewed By: robhogan Differential Revision: D58285587
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58285587 |
Contributor
|
This pull request has been merged in d72ac96. |
|
This pull request was successfully merged by @huntie in d72ac96. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As titled. The
vmfield is not part of the CDP spec and will not be used by the modern debugger frontend or proxy.This change affects modern CDP targets only (using
InspectorPackagerConnection). We aim to enable sharing of more detailed metadata over 1/ a new, dedicated CDP domain, and 2/ namespaced under the existingreactNativefield (for the latter, strictly limited to metadata necessary for dev server functionality).Changelog: [Internal]
(Note:
/jsonendpoint behaviour is unchanged for legacy CDP targets)Differential Revision: D58285587