Remove import of com.facebook.react.ReactSettingsExtension#44850
Closed
cortinico wants to merge 1 commit into
Closed
Remove import of com.facebook.react.ReactSettingsExtension#44850cortinico wants to merge 1 commit into
com.facebook.react.ReactSettingsExtension#44850cortinico wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58354443 |
…k#44850) Summary: Pull Request resolved: facebook#44850 I'm removing this line from settings.gradle: ``` import com.facebook.react.ReactSettingsExtension ``` and just using a fully qualified class name in the `configure{}` block as imports cannot be conditionally included and is making hard for RNTA to integrated those changes. Changelog: [Internal] [Changed] - Remove import of `com.facebook.react.ReactSettingsExtension` Reviewed By: huntie Differential Revision: D58354443
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58354443 |
cortinico
force-pushed
the
export-D58354443
branch
from
ddfbe04 to
8defb50
Compare
|
This pull request was successfully merged by @cortinico in feeb4b7. When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been merged in feeb4b7. |
Base commit: 6937c70 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I'm removing this line from settings.gradle:
and just using a fully qualified class name in the
configure{}blockas imports cannot be conditionally included and is making hard for RNTA
to integrated those changes.
Changelog:
[Internal] [Changed] - Remove import of
com.facebook.react.ReactSettingsExtensionDifferential Revision: D58354443