Skip to content

Simplify build_android#44870

Closed
cortinico wants to merge 1 commit intofacebook:mainfrom
cortinico:export-D58407537
Closed

Simplify build_android#44870
cortinico wants to merge 1 commit intofacebook:mainfrom
cortinico:export-D58407537

Conversation

@cortinico
Copy link
Copy Markdown
Contributor

Summary:
This just simplifies the build_android step on GHA

Changelog:
[Internal] [Changed] - Simplify build_android

Differential Revision: D58407537

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 11, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D58407537

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Jun 11, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,248,995 +9
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,454,721 -4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 3303dd3
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D58407537

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D58407537

Summary:
Pull Request resolved: facebook#44870

This just simplifies the build_android step on GHA

Changelog:
[Internal] [Changed] - Simplify build_android

Reviewed By: cipolleschi

Differential Revision: D58407537
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D58407537

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 11, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in d0012b7.

@github-actions
Copy link
Copy Markdown

This pull request was successfully merged by @cortinico in d0012b7.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants