Update RN Share.share()'s argument types to be more explicit#44887
Closed
charlesbdudley wants to merge 1 commit into
Closed
Update RN Share.share()'s argument types to be more explicit#44887charlesbdudley wants to merge 1 commit into
charlesbdudley wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58224906 |
Base commit: 49a911f |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58224906 |
charlesbdudley
force-pushed
the
export-D58224906
branch
from
267284d to
57779aa
Compare
…k#44887) Summary: Pull Request resolved: facebook#44887 The previous inexact object types and documentation for Share.share()'s arguments have led to confusion in how this library should be used. This diff updates the argument types to be more explicit, and rewrites some of the documentation for clarity. Changelog: [General][Breaking] Update `Share.share()`'s argument types to be more explicit. Reviewed By: NickGerleman Differential Revision: D58224906
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58224906 |
charlesbdudley
force-pushed
the
export-D58224906
branch
from
57779aa to
3f8368f
Compare
Contributor
|
This pull request has been merged in 8b53d41. |
|
This pull request was successfully merged by Charles Dudley in 8b53d41. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The previous inexact object types and documentation for Share.share()'s arguments have led to confusion in how this library should be used. This diff updates the argument types to be more explicit, and rewrites some of the documentation for clarity.
Changelog:
[General][Breaking] Update
Share.share()'s argument types to be more explicit.Differential Revision: D58224906