Destructure all overridden props#44910
Closed
pieterv wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58446569 |
Base commit: 18be49e |
Differential Revision: D58391419
Summary: Pull Request resolved: facebook#44910 Props within the `Text` component are accessed both via destructuring the props object but also in some cases by using a "dot" access on the destructured `restProps`. However in all of the "dot" access cases the property is being overrided. Which means in the final JSX these properties get set twice, e.g. via the `restProps` spread then overrrided by static properties. This change just destructures all values to avoid this inefficiency. Changelog: [Internal] Reviewed By: javache Differential Revision: D58446569
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58446569 |
pieterv
force-pushed
the
export-D58446569
branch
from
56c7bd3 to
0603d5e
Compare
Contributor
|
This pull request has been merged in a237e8d. |
|
This pull request was successfully merged by @pieterv in a237e8d. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Props within the
Textcomponent are accessed both via destructuring the props object but also in some cases by using a "dot" access on the destructuredrestProps. However in all of the "dot" access cases the property is being overrided. Which means in the final JSX these properties get set twice, e.g. via therestPropsspread then overrrided by static properties. This change just destructures all values to avoid this inefficiency.Changelog: [Internal]
Reviewed By: javache
Differential Revision: D58446569