fix: make it possible to add multiple mountingOverrideDelegates

[WoLewicki]

Summary:

PR changing the single mountingOverrideDelegate to a vector of those, so other listeners can operate on the transaction. Used by react-native-screens in software-mansion/react-native-screens#2134 and react-native-reanimated in software-mansion/react-native-reanimated#6055.

Till now, only one listener could be added there, meaning that e.g. Layout Animations from react-native, Layout Animations from react-native-reanimated and listening for Screen removal in react-native-screens could not operate at the same time.

Changelog:

[GENERAL] [FIXED] - Add option for multiple mountingOverrideDelegates

Test Plan:

The code of LayoutAnimations inside react-native should work the same since it will add just one listener then. For other cases, different libraries can read/mutate transactions.

[WoLewicki]

I am aware that the name of the method should be probably changed from setMountingOverrideDelegate to addMountingOverrideDelegate but this way we keep the compatibility between versions.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	20,365,514	+993
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	23,569,569	-62
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 8b53d41
Branch: main

[sammy-SC]

shouldn't this be renamed to 'addMountingOverrideDelegate'?

[facebook-github-bot]

@sammy-SC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[sammy-SC]

looks good. I'm importing the diff. If you manage to do the rename, that's great. Otherwise, it can be done in subsequent diff.

Thank you

[WoLewicki]

As mentioned in #44927 (comment), not changing the name would make it work for different RN versions, but since we don't care too much about it on new arch right now, I'll change it 😅

[WoLewicki]

@sammy-SC changed from set to add.

[facebook-github-bot]

@sammy-SC merged this pull request in 358fe46.

[github-actions]

This pull request was successfully merged by @WoLewicki in 358fe46.

^{When will my fix make it into a release? | How to file a pick request?}