Skip to content

[RN][GHA] Properly export the hermes tarball path to reuse it in RNTester#44931

Closed
cipolleschi wants to merge 1 commit intomainfrom
cipolleschi/fix-rntester-cache-gha
Closed

[RN][GHA] Properly export the hermes tarball path to reuse it in RNTester#44931
cipolleschi wants to merge 1 commit intomainfrom
cipolleschi/fix-rntester-cache-gha

Conversation

@cipolleschi
Copy link
Copy Markdown
Contributor

@cipolleschi cipolleschi commented Jun 13, 2024

Summary:

While working on GHA, I realized that RNTester is not reusing the hermes package we create in the previous steps.

This change should fix that, saving ~5 minute per RNTester test as it does not have to rebuild hermes every time.

Changelog:

[Internal] - Improve CI to reuse hermes tarballs

Test Plan:

Before After
Screenshot 2024-06-13 at 16 02 32 Screenshot 2024-06-13 at 16 34 20

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 13, 2024
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-rntester-cache-gha branch from e252735 to 96de9ef Compare June 13, 2024 15:20
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-rntester-cache-gha branch from 96de9ef to 78c641f Compare June 13, 2024 15:35
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,364,462 -9
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,569,578 -11
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 1c6bf24
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 14, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi merged this pull request in c7d3220.

@github-actions
Copy link
Copy Markdown

This pull request was successfully merged by @cipolleschi in c7d3220.

When will my fix make it into a release? | How to file a pick request?

@cortinico cortinico deleted the cipolleschi/fix-rntester-cache-gha branch November 4, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants