[RN][GHA] Properly export the hermes tarball path to reuse it in RNTester#44931
Closed
cipolleschi wants to merge 1 commit intomainfrom
Closed
[RN][GHA] Properly export the hermes tarball path to reuse it in RNTester#44931cipolleschi wants to merge 1 commit intomainfrom
cipolleschi wants to merge 1 commit intomainfrom
Conversation
e252735 to
96de9ef
Compare
96de9ef to
78c641f
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 1c6bf24 |
Contributor
|
@cipolleschi merged this pull request in c7d3220. |
|
This pull request was successfully merged by @cipolleschi in c7d3220. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
While working on GHA, I realized that RNTester is not reusing the hermes package we create in the previous steps.
This change should fix that, saving ~5 minute per RNTester test as it does not have to rebuild hermes every time.
Changelog:
[Internal] - Improve CI to reuse hermes tarballs
Test Plan: