Add test showcasing memory leak in RemoteObjectsTable in Hermes#44936
Closed
hoxyq wants to merge 1 commit into
Closed
Add test showcasing memory leak in RemoteObjectsTable in Hermes#44936hoxyq wants to merge 1 commit into
hoxyq wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58531763 |
Base commit: 8b53d41 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58531763 |
…book#44936) Summary: Pull Request resolved: facebook#44936 # Changelog: [Internal] Added a small test that uses `folly:ManualExecutor`, which reproduces the memory leak issue in Hermes' RemoteObjectsTable: 1. Send `Runtime.enable` 2. Evaluate `console.log(<object>);` to populate `RemoteObjectsTable` 3. Send `Page.reload` to reload VM This test is expected to fail, because by the time it is published, the D58398254 hasn't landed. Reviewed By: motiz88 Differential Revision: D58531763
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58531763 |
|
This pull request was successfully merged by @hoxyq in 7bd98ee. When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been merged in 7bd98ee. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Added a small test that uses
folly:ManualExecutor, which reproduces the memory leak issue in Hermes' RemoteObjectsTable:Runtime.enableconsole.log(<object>);to populateRemoteObjectsTablePage.reloadto reload VMThis test is expected to fail, because by the time it is published, the D58398254 hasn't landed.
Differential Revision: D58531763