Skip to content

Add package.json to default lockFiles for ReactSettingsExtension#44948

Closed
cortinico wants to merge 1 commit into
facebook:mainfrom
cortinico:export-D58587739
Closed

Add package.json to default lockFiles for ReactSettingsExtension#44948
cortinico wants to merge 1 commit into
facebook:mainfrom
cortinico:export-D58587739

Conversation

@cortinico
Copy link
Copy Markdown
Contributor

Summary:
This is a small improvement suggested by tido64 to also account for package.json when computing caching
for autolinking of libraries.

Changelog:
[Internal] [Changed] - Add package.json to default lockFiles for ReactSettingsExtension

Differential Revision: D58587739

Summary:
This is a small improvement suggested by tido64 to also account for package.json when computing caching
for autolinking of libraries.

Changelog:
[Internal] [Changed] - Add package.json to default `lockFiles` for ReactSettingsExtension

Differential Revision: D58587739
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 14, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D58587739

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,365,550 -5
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,569,609 -20
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 7061649
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 14, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 9c7c955.

@github-actions
Copy link
Copy Markdown

This pull request was successfully merged by @cortinico in 9c7c955.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants