Fix for broken test_helloworld_android on Release#44952
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
Summary: The test_helloworld_android Release variant are broken on GHA. This fixes it as it forces hermesc to be built *before* the app attempts to create a bundle. Changelog: [Internal] [Changed] - Fix for broken test_helloworld_android on Release Reviewed By: cipolleschi, blakef Differential Revision: D58591480
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58591480 |
Base commit: 2e2b71e |
Contributor
|
This pull request has been merged in 2b640be. |
|
This pull request was successfully merged by @cortinico in 2b640be. When will my fix make it into a release? | How to file a pick request? |
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The test_helloworld_android Release variant are broken on GHA.
This fixes it as it forces hermesc to be built before the app attempts to create a bundle.
Changelog:
[Internal] [Changed] - Fix for broken test_helloworld_android on Release
Reviewed By: cipolleschi, blakef
Differential Revision: D58591480