Skip to content

RN: Remove react-shallow-renderer Dependency#44982

Closed
yungsters wants to merge 14 commits into
facebook:mainfrom
yungsters:export-D58643454
Closed

RN: Remove react-shallow-renderer Dependency#44982
yungsters wants to merge 14 commits into
facebook:mainfrom
yungsters:export-D58643454

Conversation

@yungsters
Copy link
Copy Markdown
Contributor

Summary:
Removes react-shallow-renderer dependency from the react-native package because it is no longer used.

Changelog:
[Internal]

Differential Revision: D58643454

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 16, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D58643454

yungsters added 11 commits June 15, 2024 21:06
facebook#44972)

Summary:
Pull Request resolved: facebook#44972

Migrates this Jest unit test away from using `react-shallow-renderer` because it is no longer recommended.

Changelog:
[Internal]

Differential Revision: D58643055
…acebook#44983)

Summary:
Pull Request resolved: facebook#44983

Migrates this Jest unit test away from using `react-shallow-renderer` because it is no longer recommended.

Changelog:
[Internal]

Differential Revision: D58643056
…derer (facebook#44986)

Summary:
Pull Request resolved: facebook#44986

Migrates this Jest unit test away from using `react-shallow-renderer` because it is no longer recommended.

Changelog:
[Internal]

Differential Revision: D58643069
…facebook#44969)

Summary:
Pull Request resolved: facebook#44969

Migrates this Jest unit test away from using `react-shallow-renderer` because it is no longer recommended.

Changelog:
[Internal]

Differential Revision: D58643057
facebook#44976)

Summary:
Pull Request resolved: facebook#44976

Migrates this Jest unit test away from using `react-shallow-renderer` because it is no longer recommended.

Changelog:
[Internal]

Differential Revision: D58643067
…ook#44971)

Summary:
Pull Request resolved: facebook#44971

Migrates this Jest unit test away from using `react-shallow-renderer` because it is no longer recommended.

Changelog:
[Internal]

Differential Revision: D58643068
…er (facebook#44981)

Summary:
Pull Request resolved: facebook#44981

Migrates this Jest unit test away from using `react-shallow-renderer` because it is no longer recommended.

Changelog:
[Internal]

Differential Revision: D58643062
…cebook#44975)

Summary:
Pull Request resolved: facebook#44975

These Jest unit test cases were making assertions about shallow rendering, but that shallow rendering is now deprecated.

Changelog:
[Internal]

Differential Revision: D58643064
Summary:
Pull Request resolved: facebook#44970

These Jest unit test cases were making assertions about shallow rendering, but that shallow rendering is now deprecated.

Changelog:
[Internal]

Differential Revision: D58643058
Summary:
Pull Request resolved: facebook#44977

These Jest unit test cases were making assertions about shallow rendering, but that shallow rendering is now deprecated.

Changelog:
[Internal]

Differential Revision: D58643060
…ook#44980)

Summary:
Pull Request resolved: facebook#44980

These Jest unit test cases were making assertions about shallow rendering, but that shallow rendering is now deprecated.

Changelog:
[Internal]

Differential Revision: D58643065
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Jun 16, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,365,775 -4
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,569,736 -1
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: d75a28d
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D58643454

robhogan pushed a commit to robhogan/react-native that referenced this pull request Jun 16, 2024
Summary:
Pull Request resolved: facebook#44982

Removes `react-shallow-renderer` dependency from the `react-native` package because it is no longer used.

Changelog:
[Internal]

Differential Revision: D58643454
Summary:
Pull Request resolved: facebook#44984

Deletes the `jest/renderer` shallow render helpers.

The commit stack below this already migrated all references to `shallow` and `shallowRender`.

Changelog:
[Internal]

Differential Revision: D58643063
Summary:
Pull Request resolved: facebook#44973

Changes `expectRendersMatchingSnapshot` to no longer make assertions about shallow rendering, because shallow rendering is now deprecated.

Changelog:
[Internal]

Differential Revision: D58643365
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D58643454

Summary:
Pull Request resolved: facebook#44982

Removes `react-shallow-renderer` dependency from the `react-native` package because it is no longer used.

Changelog:
[Internal]

Reviewed By: robhogan

Differential Revision: D58643454
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D58643454

robhogan pushed a commit to robhogan/react-native that referenced this pull request Jun 16, 2024
Summary:
Pull Request resolved: facebook#44982

Removes `react-shallow-renderer` dependency from the `react-native` package because it is no longer used.

Changelog:
[Internal]

Differential Revision: D58643454
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 16, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in ffc0640.

@yungsters yungsters deleted the export-D58643454 branch March 13, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants