Wrap jest/renderer create abstraction in act for concurrent rendering#44994
Closed
robhogan wants to merge 6 commits into
Closed
Wrap jest/renderer create abstraction in act for concurrent rendering#44994robhogan wants to merge 6 commits into
jest/renderer create abstraction in act for concurrent rendering#44994robhogan wants to merge 6 commits into
Conversation
Differential Revision: D58647827
Differential Revision: D58647828
Differential Revision: D58649295
…reparation for React 19 Summary: Use our existing thin abstraction around `react-test-renderer` `create` within `react-native/jest/renderer`, in order to benefit from the introduction of async `act` wrapping in that abstraction. Changelog: [Internal] Differential Revision: D58650874
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58650940 |
Differential Revision: D58651811
…dering (facebook#44994) Summary: Pull Request resolved: facebook#44994 For RN monorepo tests, wrap `create` calls through our `jest/renderer` abstraction in `await act`. This is a no-op under current React but will be required under `react-test-renderer@19` with `IS_REACT_ACT_ENVIRONMENT`. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D58650940
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58650940 |
robhogan
force-pushed
the
export-D58650940
branch
from
e75c7df to
98f4bfc
Compare
Contributor
|
This pull request has been merged in 132e2a3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
For RN monorepo tests, wrap
createcalls through ourjest/rendererabstraction inawait act.This is a no-op under current React but will be required under
react-test-renderer@19withIS_REACT_ACT_ENVIRONMENT.Changelog: [Internal]
Differential Revision: D58650940