Add missing acts to VirtualizedList-test and migrate to async act#44997
Closed
robhogan wants to merge 1 commit into
Closed
Add missing acts to VirtualizedList-test and migrate to async act#44997robhogan wants to merge 1 commit into
acts to VirtualizedList-test and migrate to async act#44997robhogan wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58649295 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58649295 |
robhogan
force-pushed
the
export-D58649295
branch
from
41854de to
2027625
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58649295 |
robhogan
force-pushed
the
export-D58649295
branch
from
2027625 to
5b19c08
Compare
…acebook#44997) Summary: Pull Request resolved: facebook#44997 Wrap `VirtualizedList-test` uses of `react-test-renderer` in `act` as appropriate, so as to pass under current React and mostly pass under React 19, with further fixes to come. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D58649295
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58649295 |
robhogan
force-pushed
the
export-D58649295
branch
from
5b19c08 to
6929059
Compare
Contributor
|
This pull request has been merged in fe06cbf. |
|
This pull request was successfully merged by @yungsters in fe06cbf. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Wrap
VirtualizedList-testuses ofreact-test-rendererinactas appropriate, so as to pass under current React and mostly pass under React 19, with further fixes to come.Changelog: [Internal]
Reviewed By: yungsters
Differential Revision: D58649295